Support multiword mention autocomplete sessions - #2345
Merged
Conversation
ymichael
force-pushed
the
fix/spaced-mention-autocomplete
branch
from
August 25, 2026 20:33
722353e to
5d3f6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The prompt mention trigger scanner treated every space as the end of an
@query. Thread matching already supported multiword titles, but the editor stopped dispatching the query at the first space, so those matches were unreachable.Extending a dismissed multiword occurrence could also reopen autocomplete because dismissal was tied to the original text range. Touch layouts had no explicit way to dismiss results while preserving the typed text, and deleting then retyping a dismissed occurrence could leave the new occurrence suppressed.
What changed
Mention queries now preserve ordinary spaces verbatim. Tabs, newlines, punctuation handling, the initially highlighted result, Enter, Tab, matching, and ranking retain their previous behavior.
Dismissal now follows the same trigger occurrence as its text grows. Removing or replacing that occurrence clears the dismissal so a newly typed
@can trigger autocomplete again.Coarse-pointer layouts get a 44×44
Close suggestionstarget. It shares the first section/status row rather than adding a separate header, preserving the touch target without extra vertical space. Desktop menus remain unchanged.No wire contracts or protocol versions changed.
How you verified
Fixes: N/A (no linked issue).